Repository navigation
A species or fuel class absent from the vegetation is 0 for a stored fit - #46
Closed
eliotmcintire wants to merge 2 commits into
Closed
eliotmcintire wants to merge 2 commits into
eliotmcintire wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
…ks; exclude drought indices from species columns Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6
Collaborator
Author
|
Closing: a species missing from the run's vegetation should stop the run, not become zero biomass. The one case that hit this (11.3 Pinu_con) was a stale ELF map, which a silent zero would have hidden. That map bug is fixed in fireSense_ELFs#49. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A saved spread model can predict in a run whose vegetation lacks a fuel class the model was trained with. The missing class is treated as having no biomass.
Affects: Runs whose vegetation lacks a fuel class of the fitted spread model predict with no biomass for it instead of stopping with "have no covariate"; climate, non-forest and other missing covariates still stop.
Depends-on: PredictiveEcology/fireSenseUtils#245
Technical details
Defect:
fireSense_spreadPredict.RspreadProbOneELF()stopped (noCov) for any fitted covariate missing fromcovs. Fix:addAbsentSpeciesCols(covs, needed, value = logMinB(0))(the valuefuelCovsToCoarse()gives a class with no biomass) before the fuel-scale handling, so a linear-fuel fit undoes the log for it too and rescaling is unchanged.neededisspreadSourceCols(fitted), so interaction terms are not mistaken for species. The test that a missing interaction fuel covariate stops now expects the 0-biomass prediction and checks that a missingyoungAgestill stops.Update: with an unseen fuel covariate in the covariates, an absent fitted fuel class is not zero-filled and the existing stop stays (a new test checks it).
Reuses:
fireSenseUtils::addAbsentSpeciesCols()/absentSpeciesCols()/foldFeatureNames()(fireSenseUtils#245); new: none (the helper lives in fireSenseUtils so the three modules share it).Tests: new test in
test-youngAgeExclusivity.R(linear-fuel and log-scale fits equal an explicitlogMinB(0)column) and the rewritten interaction test. Branch: 363 passed, 0 failed, 0 skipped. Base with the new tests: 357 passed, 2 errors (the new tests). No version bump; thereqdPkgsfloor for the new fireSenseUtils functions is set after fireSenseUtils#245 merges. Scratch library/home/emcintir/R/scratch-absent(fireSenseUtils branch installed).🤖 Generated with Claude Code
https://claude.ai/code/session_014G18Mik3fH4z5M5CyMSUS6